fix(types): widen vite peer dependency to ^5.4.21 || ^6 || ^7 so npm installs succeed on Vite 6/7 - #16248
fix(types): widen vite peer dependency to ^5.4.21 || ^6 || ^7 so npm installs succeed on Vite 6/7#16248pevey wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 2c0b2b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 79 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! We need more information before reviewing this further. The PR proposes widening the Vite peer dependency range to support Vite 6 and 7. The What section references the linked issue, but the Why, How, and Testing sections of the PR template still contain placeholder text and must be filled in before the review can proceed. Triggered by: new PR opened |
|
Thanks for the contribution! A few items need to be addressed before this can move forward: External contributor PR widening the vite optional peer dependency in @medusajs/types from ^5.4.21 to ^5.4.21 || ^6 || ^7. The change is technically correct for the stated scope. However, @medusajs/admin-vite-plugin also declares vite ^5.4.21 as a peer dep and is not updated; users on Vite 6/7 would still encounter peer dep conflicts from that package. Template sections are minimally filled with links to the linked issue.
Triggered by: PR description updated |
|
Hi @pevey we're planning to update vite across the packages next week, so I'll close this PR in favor of that. Thank you for contributing! |
|
Please take a look at the issue. It's not really related to updating vite. It widens a dead peerDep that blocks installs in consuming apps that use vite. |
shahednasser
left a comment
There was a problem hiding this comment.
Approving the PR, but it will not be released and might be changed as we update vite before the next release.
|
@pevey you need to update the lock file |
Summary
What — What changes are introduced in this PR?
Addresses #16247
Why — Why are these changes relevant or necessary?
See #16247
How — How have these changes been implemented?
See #16247
Testing — How have these changes been tested, or how can the reviewer test the feature?
See #16247
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
// Example usageChecklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.