Skip to content

fix(types): widen vite peer dependency to ^5.4.21 || ^6 || ^7 so npm installs succeed on Vite 6/7 - #16248

Open
pevey wants to merge 2 commits into
medusajs:developfrom
pevey:fix/types-vite-peer-range
Open

fix(types): widen vite peer dependency to ^5.4.21 || ^6 || ^7 so npm installs succeed on Vite 6/7#16248
pevey wants to merge 2 commits into
medusajs:developfrom
pevey:fix/types-vite-peer-range

Conversation

@pevey

@pevey pevey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

What — What changes are introduced in this PR?

Addresses #16247

Why — Why are these changes relevant or necessary?

See #16247

How — How have these changes been implemented?

See #16247

Testing — How have these changes been tested, or how can the reviewer test the feature?

See #16247


Examples

Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.

// Example usage

Checklist

Please ensure the following before requesting a review:

  • [X ] I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • [X ] I have verified the code works as intended locally
  • [X ] I have linked the related issue(s) if applicable

Additional Context

Add any additional context, related issues, or references that might help the reviewer understand this PR.

@pevey
pevey requested a review from a team as a code owner July 30, 2026 23:09
@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2c0b2b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 79 packages
Name Type
@medusajs/types Patch
@medusajs/event-bus-redis Patch
@medusajs/draft-order Patch
@medusajs/loyalty-plugin Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/query Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/medusa-oas-cli Patch
@medusajs/admin-bundler Patch
@medusajs/dashboard Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/rbac Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/translation Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
integration-tests-http Patch
@medusajs/oas-github-ci Patch
@medusajs/http-types-generator Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/eslint-plugin Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@medusa-os-bot

medusa-os-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

Thanks for the contribution! We need more information before reviewing this further.

The PR proposes widening the Vite peer dependency range to support Vite 6 and 7. The What section references the linked issue, but the Why, How, and Testing sections of the PR template still contain placeholder text and must be filled in before the review can proceed.

Triggered by: new PR opened

@medusa-os-bot

medusa-os-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

Thanks for the contribution! A few items need to be addressed before this can move forward:

External contributor PR widening the vite optional peer dependency in @medusajs/types from ^5.4.21 to ^5.4.21 || ^6 || ^7. The change is technically correct for the stated scope. However, @medusajs/admin-vite-plugin also declares vite ^5.4.21 as a peer dep and is not updated; users on Vite 6/7 would still encounter peer dep conflicts from that package. Template sections are minimally filled with links to the linked issue.

  • packages/admin/admin-vite-plugin/package.json also restricts vite to ^5.4.21 as a peer dep and is not updated in this PR. Users on Vite 6/7 still see peer dep errors from that package. Widen its range to match, or explain why it intentionally stays on Vite 5.

Triggered by: PR description updated

@shahednasser

Copy link
Copy Markdown
Member

Hi @pevey we're planning to update vite across the packages next week, so I'll close this PR in favor of that. Thank you for contributing!

@pevey

pevey commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Please take a look at the issue. It's not really related to updating vite. It widens a dead peerDep that blocks installs in consuming apps that use vite.

@shahednasser shahednasser reopened this Jul 31, 2026

@shahednasser shahednasser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR, but it will not be released and might be changed as we update vite before the next release.

@shahednasser

Copy link
Copy Markdown
Member

@pevey you need to update the lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants