Feat/dedicated repl user - #33
Merged
Merged
Conversation
…hurn ensureConfigMap did an unconditional r.Update on every reconcile, bumping the ConfigMap's resourceVersion and emitting an audit event each pass even when nothing changed — the same fleet-scale churn class already fixed for Service/NetworkPolicy/StatefulSet/CronJob. Gate the Update behind an exact DeepEqual of Data plus a labels-contained check. Data is fully operator-specified with no API-server-defaulted keys, so an exact compare is correct (no shrinkable list, unlike the STS/CronJob pod templates). The config hash driving the pod rollout annotation is still returned on both paths, unchanged. Add TestEnsureConfigMapSkipsNoOpAndUpdatesOnChange mirroring the sibling churn tests: a no-op reconcile keeps resourceVersion and hash stable; a rotated password re-renders valkey.conf and still writes.
melancholictheory
force-pushed
the
feat/dedicated-repl-user
branch
from
August 3, 2026 20:25
4cefa45 to
8abb3c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related issues
Type of change
Checklist
make manifests generaterun and generated files committed (if API/RBAC/webhook changed)make lintpassesmake testpassesdocs/,README.md, or CRD reference) if behavior changedNotes for reviewers