don't hardcode a version suffix in the libwayland-egl dlopen - #2426
Closed
Izder456 wants to merge 1 commit into
Closed
don't hardcode a version suffix in the libwayland-egl dlopen#2426Izder456 wants to merge 1 commit into
Izder456 wants to merge 1 commit into
Conversation
Contributor
|
This can (and will) break other *nix platforms. Generally, the non-suffix variant is only available as a dev package (as a symlink for building purposes). That suffix indicates the ABI version, and if it's not 1 in this case, that means the ABI is different, and therefore you cannot assume you can even correctly handle whatever you're trying to link. |
Contributor
Author
|
Alrighty then. I'll go and close this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was discovered by thfr on the OpenBSD ports mailing list. Hardcoding this is not very portable. Shouldn't break other *NIX platforms like Darwin or Linux.