Use Qt's QFile abstraction for the Platform.h file I/O functions - #2646
Merged
Conversation
Zection6V
pushed a commit
to ag-advania/melonPrimeDS
that referenced
this pull request
Aug 13, 2026
…onDS-emu#2646) * Use Qt's QFile abstraction for the Platform.h file I/O functions * forgot to reimplement FileWriteFormatted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
melonDS is currently rather pointlessly opening files through Qt and then duplicating and reopening the file with the stdio file functions, there's not really any reason to do this anymore since the core no longer works with plain
FILE*s, and since we're using Qt for the frontend, I feel it would be more appropriate to also have Qt's file abstractions handle this.Avoiding this hack also means we don't need to worry about Windows's stdio weirdness and might hopefully also improve robustness of melonDS's file operations a bit.