Disable portable mode by default on Windows - #2677
Open
nadiaholmquist wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes melonDS on Windows behave like it does in regard to its config directory on other platforms by default. The config file will now go in
C:\Users\<username>\AppData\Local\melonDS.I've added a check for whether the config file already exists in the executable path for backwards compatibility so this doesn't break people's pre-existing setups.
The motivation for this is that a lot of users get confused by the default behavior, either from not knowing that melonDS needs to be stored in a writable directory, or from presumably file synchronization tools marking paths in e.g. the user Documents folder as read-only, and melonDS suddenly failing to write its config file. Local AppData should always be a safe path to write into, so this will lead to less surprising error-prone behavior for users.
Remember that if you do want a portable version anyway, you can make a
portabledirectory next to the executable and it will be used instead of the AppData path.