NocashPrint: Fix can't print from ITCM/DTCM - #2715
Open
Prof9 wants to merge 1 commit into
Open
Conversation
Member
|
we probably need a separate debug memory read/write function at some point for the GDB interface as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No$gba defines a printing mechanism using pseudo IO ports, which melonDS also supports. In No$gba, printing a string in TCM works fine, but in melonDS it doesn't (yields an unknown arm9 read warning).
This happens because melon effectively emulates the read as a bus read, calling NDS::ArmXRead8 which skips the TCM check (which is implemented in the ARM module). This PR changes it to a read via CPU, which defers to a bus read if the address is not in TCM.
This does have a side effect of updating DataCycles in the ARM instance, but I don't think this should be a problem here? It will also cause a data abort if the address being printed is not mapped , but I don't think that's a use case. Debug printing is a development feature anyway.
Reference: https://problemkaputt.de/gbatek.htm#dsdebugregistersemulatordevkits