Add fast-forward and slow-mo audio volume settings - #2736
Open
Davey-Hughes wants to merge 1 commit into
Open
Conversation
Muting while fast-forwarding is all-or-nothing, and the existing setting only reacted to the fast-forward hotkeys. Turning off Config -> Limit framerate also runs well above 100% speed but was never covered, which is half of what issue melonDS-emu#2056 asked for. Fast-forward and slow-mo now each get an independent volume, as a percentage of the normal volume, so it composes with the volume slider and with DSi volume sync. 100% leaves the audio alone, 0% mutes, and above 100% is louder than normal play. The trigger compares curFPS against targetFPS instead of reading the hotkey flags. That picks up the frame-limiter case for free, and leaves audio alone when audio sync is already pacing playback to real time. MuteFastForward is reused as the fast-forward enable and FastForwardVolume defaults to 0, so a config that already had muting turned on keeps muting without any migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw this issue and didn't realize that the fix had already been merged, but I enhanced the feature if we want it.
I basically made it so you could set a volume from 0% to 200 as a percentage of the master volume on fast-foward or slo-mo (as separate sliders). One other change from how it works compared to what's on master right now is that the volume percentage you set for fast-foward applies to the uncapped speed as well.
Anyway if this feature is not needed then no worries and this PR can be closed.