feat: allow templating in secrets.name - #247
Merged
Merged
Conversation
Use tpl function for secrets.name references so users can use
Go template expressions like {{ .Release.Name }}-secrets.
Plain string values continue to work unchanged.
Affected charts:
- memgraph
- memgraph-lab
- memgraph-high-availability
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
as51340
added
memgraph-ha
as51340
added
feature
as51340
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Go template expressions in
secrets.namevalues by wrapping references with thetplfunction.Example
Changes
Uses
tplforsecrets.namein:charts/memgraph/templates/statefulset.yamlcharts/memgraph-lab/templates/deployment.yamlcharts/memgraph-high-availability/templates/coordinators.yamlcharts/memgraph-high-availability/templates/data.yamlPlain string values (e.g.
memgraph-secrets) continue to work unchanged.Validation
All three charts verified with
helm template:{{ .Release.Name }}-secrets) resolves correctly