fix: hardcode user_id, disallow user override - #7
Open
HQidea wants to merge 1 commit into
Open
Conversation
Align with memorylake-openclaw pattern — user_id is no longer configurable via MEMORYLAKE_USER_ID env var, memorylake.json, or runtime kwargs. It is always set to "default" after config loading to prevent any override path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_idto"default"across the entire plugin, aligning with the memorylake-openclaw patternMEMORYLAKE_USER_IDenvironment variable support from all config sources (env vars,memorylake.json, runtime kwargs)user_idis now set after thememorylake.jsonoverlay merge, ensuring no override path existsChanged files
src/memorylake_hermes/__init__.py— hardcodeself._user_id = "default", remove docstring referencesrc/memorylake_hermes/get_config.py— remove env var read, hardcode after overlaysrc/memorylake_hermes/skills/memorylake/*/scripts/get_config.py(×3) — same patternREADME.md— removeMEMORYLAKE_USER_IDfrom env var tableTest plan
MEMORYLAKE_USER_IDenv var is ignored when setuser_idinmemorylake.jsonis overridden to"default"user_id = "default"in logs"default"as user_id🤖 Generated with Claude Code