Add support for authorization code grant with PKCE for distributed apps#4
Open
ls-youssef-jlidat wants to merge 1 commit intomainfrom
Open
Add support for authorization code grant with PKCE for distributed apps#4ls-youssef-jlidat wants to merge 1 commit intomainfrom
ls-youssef-jlidat wants to merge 1 commit intomainfrom
Conversation
move handlers for code challenge from OIDC Authorization Controller to the base authorization controller, so that non-OIDC flows can leverage it as well Add mechanism to enforce PKCE code challenges for public clients Add mechanism to configure supported code challenge methods change code_verifier comparison to use hash_equals() to avoid timing attacks added tests for all PKCE code challenge flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bshaffer/oauth2-server-phpmain branch1c715c2- add explicit null to nullable types)de7e02d) on top of the updated baseContext
1.15.0(tag on originalsupport-acg-with-pkcebranch)1.15.1to be created from this branch after merge