fix: stop returning when err so diagram can be rendered post error fix#1449
Open
ad1992 wants to merge 1 commit intomermaid-js:developfrom
Open
fix: stop returning when err so diagram can be rendered post error fix#1449ad1992 wants to merge 1 commit intomermaid-js:developfrom
ad1992 wants to merge 1 commit intomermaid-js:developfrom
Conversation
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
cc @sidharthv96 |
Author
|
friendly reminder @sidharthv96 |
sidharthv96
requested changes
May 21, 2024
Comment on lines
64
to
68
| if (state.error !== undefined) { | ||
| error = true; | ||
| errorLines = state.error.toString().split('\n'); | ||
| return; | ||
| } | ||
| error = false; |
Member
There was a problem hiding this comment.
If return is removed, error is set as false immediately. So something else needs to be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
Currently in production if for any reason an error occurs, the diagram gets stuck and isn't rendered even after error is fixed hence I have fixed that in this PR
eg, try with below code and config in prod vs this PR
change the config to
2and change it back to10-> In prod the diagrams will not rerender until refresh.developbranch