Skip to content

chore: optimize tilt animation by skipping offscreen updates inside hero-glass.js #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Katotodan wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: optimize tilt animation by skipping offscreen updates inside hero-glass.js #208

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d38e2f9
chore hero-glass
Katotodan Apr 27, 2026
9af84c7
Optimize tilt animation by skipping offscreen updates
Katotodan Apr 27, 2026
ba4125f
fix offscreen till update
Katotodan May 9, 2026
eb2958a
Merge branch 'master' into chore/hero-glass
Katotodan Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions static/scripts/hero-glass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,19 @@ const updateScene = () => {
root.style.setProperty("--cursor-x", `${pointer.x}px`);
root.style.setProperty("--cursor-y", `${pointer.y}px`);

if (hero && heroInView) {
if (heroRectDirty || !heroRect) {
refreshHeroRect();
}
const relX = (pointer.x - heroRect.left) / heroRect.width - 0.5;
const relY = (pointer.y - heroRect.top) / heroRect.height - 0.5;
const clampedX = Math.max(-0.5, Math.min(0.5, relX));

@Bhumikagarggg Bhumikagarggg Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing clampedX and clampedY, which can allow excessive tilt when the pointer is far from the hero area. The optimization should skip updates when the hero is offscreen, but the tilt values should still stay clamped. please revert 37 and 38 line

const clampedY = Math.max(-0.5, Math.min(0.5, relY));
hero.style.setProperty("--tilt-x", `${(-clampedY * 7).toFixed(2)}deg`);
hero.style.setProperty("--tilt-y", `${(clampedX * 9).toFixed(2)}deg`);
if (!hero || !heroInView) {
frame = null;
return;
}

if (heroRectDirty || !heroRect) {
refreshHeroRect();
}
const relX = (pointer.x - heroRect.left) / heroRect.width - 0.5;
const relY = (pointer.y - heroRect.top) / heroRect.height - 0.5;
hero.style.setProperty("--tilt-x", `${(-relY * 7).toFixed(2)}deg`);
hero.style.setProperty("--tilt-y", `${(relX * 9).toFixed(2)}deg`);


tiltTargets.forEach((target) => {
const rect = target.getBoundingClientRect();
Comment thread
Katotodan marked this conversation as resolved.
Expand All @@ -54,7 +56,7 @@ const updateScene = () => {
const handlePointer = (event) => {
pointer.x = event.clientX;
pointer.y = event.clientY;
scheduleUpdateScene();
heroInView && scheduleUpdateScene();
};

window.addEventListener("pointermove", handlePointer, { passive: true });
Expand All @@ -74,7 +76,7 @@ window.addEventListener("scroll", () => {
heroRectDirty = true;
}, { passive: true });

if (hero) {
if(hero){
const observer = new IntersectionObserver(
(entries) => {
entries.forEach((entry) => {
Expand All @@ -85,17 +87,15 @@ if (hero) {
heroRect = null;
} else {
heroRectDirty = true;
scheduleUpdateScene();
}
scheduleUpdateScene();
});
},
{ threshold: 0.2 },
);
observer.observe(hero);
}

floaters.forEach((item, index) => {
item.style.animationDelay = `${index * -2.5}s`;
});

updateScene();
Loading