Skip to content

[chore]: build and release workflow update to match makefile changes#143

Merged
banana-three-join merged 1 commit into
meshery-extensions:masterfrom
banana-three-join:chore/banana-three-join/workflow-update
Jul 8, 2026
Merged

[chore]: build and release workflow update to match makefile changes#143
banana-three-join merged 1 commit into
meshery-extensions:masterfrom
banana-three-join:chore/banana-three-join/workflow-update

Conversation

@banana-three-join

Copy link
Copy Markdown
Contributor

Notes for Reviewers

  • This PR should be merged after chore: Standardize Makefile npm scripts #141 has been merged
  • Added Setup Go — required. make build-productioncheck-go hard-fails without it, and Hugo needs Go to resolve the academy-theme module.
  • Removed peaceiris/actions-hugo — redundant. make setup installs hugo-extended into node_modules/.bin, and make build-production reaches Hugo via npm run (which puts .bin on PATH). Dropping it also removes a second place the Hugo version was pinned.
  • make buildmake build-production — the step claims a production build test; build is the dev build.
  • academy-name now reads its declared workflow_dispatch input (${{ github.event.inputs.academy-name || 'Academy' }}) instead of being hardcoded, so the input is no longer ignored.
  • Added Setup Node (20 + npm cache) and fetch-depth: 0 to the checkout.
  • preview-deploy.yml unchanged — it bypasses make/npm run (direct hugo + npm ci), so it is unaffected by the script standardization.

Signed commits

  • Yes, I signed my commits.

… the hugo from node modules

Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-07-08 16:39 UTC

@banana-three-join banana-three-join merged commit 16b9d72 into meshery-extensions:master Jul 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant