[chore]: build and release workflow update to match makefile changes#143
Merged
banana-three-join merged 1 commit intoJul 8, 2026
Conversation
… the hugo from node modules Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Setup Go— required.make build-production→check-gohard-fails without it, and Hugo needs Go to resolve theacademy-thememodule.peaceiris/actions-hugo— redundant.make setupinstallshugo-extendedintonode_modules/.bin, andmake build-productionreaches Hugo vianpm run(which puts.binonPATH). Dropping it also removes a second place the Hugo version was pinned.make build→make build-production— the step claims a production build test;buildis the dev build.academy-namenow reads its declaredworkflow_dispatchinput (${{ github.event.inputs.academy-name || 'Academy' }}) instead of being hardcoded, so the input is no longer ignored.Setup Node(20 + npm cache) andfetch-depth: 0to the checkout.preview-deploy.ymlunchanged — it bypassesmake/npm run(directhugo+npm ci), so it is unaffected by the script standardization.Signed commits