fix: update kube-rbac-proxy image from gcr.io/kubebuilder to quay.io/brancz

[naman79820]

Description

This PR fixes #769

gcr.io/kubebuilder/kube-rbac-proxy has been discontinued and the image
v0.5.0 is no longer available on the registry, causing the meshery-operator
pod to get stuck in ImagePullBackOff and integration tests to fail on master.

Changes made:

• Updated config/default/manager_auth_proxy_patch.yaml
• Updated config/manifests/default.yaml
• Updated bundle/0.0.1/manifests/meshery-operator.clusterserviceversion.yaml

All references updated from:
gcr.io/kubebuilder/kube-rbac-proxy:v0.5.0
to:
quay.io/brancz/kube-rbac-proxy:v0.18.0

Testing:

• make integration-tests-setup completes successfully ✅
• Both kube-rbac-proxy and manager containers in Running state ✅
• pod/meshery-operator shows 2/2 Running ✅

Notes for Reviewers

quay.io/brancz/kube-rbac-proxy is the actively maintained upstream registry.
The gcr.io/kubebuilder registry was discontinued in October 2023.

Signed commits

• Yes, I signed my commits.

[welcome]

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

[naman79820]

ready for review @saurabhraghuvanshii mate :))

[marblom007]

What tests were run here, @naman79820?

[naman79820]

What tests were run here, @naman79820?

make integration-tests-setup @marblom007

[leecalcote]

Appreciate this and the verification, and thanks to the reviewers who approved.

One nuance: the recent stabilization work removed the kube-rbac-proxy sidecar from the kustomize overlay (so config/default/manager_auth_proxy_patch.yaml is already gone on master), which means part of this diff no longer applies. The retired gcr.io/kubebuilder/kube-rbac-proxy:v0.5.0 reference does still live in config/manifests/default.yaml and the bundle/0.0.1 CSV, so those are real and still need fixing.

The direction there is to drop the sidecar entirely rather than re-image it: Workstream 5 reintroduces metrics protection via the controller-runtime authn/authz filter plus cert-manager TLS, and it will regenerate the rendered manifest and bundle so the dead sidecar block (and its image) is removed completely. We will fold the still-relevant cleanup into WS-5 and supersede this PR there. Thank you for surfacing the ImagePullBackOff risk.

[marblom007]

Merge conflicts

[naman79820]

Appreciate this and the verification, and thanks to the reviewers who approved.

One nuance: the recent stabilization work removed the kube-rbac-proxy sidecar from the kustomize overlay (so config/default/manager_auth_proxy_patch.yaml is already gone on master), which means part of this diff no longer applies. The retired gcr.io/kubebuilder/kube-rbac-proxy:v0.5.0 reference does still live in config/manifests/default.yaml and the bundle/0.0.1 CSV, so those are real and still need fixing.

The direction there is to drop the sidecar entirely rather than re-image it: Workstream 5 reintroduces metrics protection via the controller-runtime authn/authz filter plus cert-manager TLS, and it will regenerate the rendered manifest and bundle so the dead sidecar block (and its image) is removed completely. We will fold the still-relevant cleanup into WS-5 and supersede this PR there. Thank you for surfacing the ImagePullBackOff risk.

Thanks @leecalcote most of this PR is already covered by the sidecar removal on master. But I noticed config/manifests/default.yaml still references the old gcr.io/kubebuilder/kube-rbac-proxy:v0.5.0 image (that registry is deprecated). Is that file also getting regenerated/removed in WS-5, or would a small one-line PR updating just that image to quay.io/brancz be useful in the meantime? Happy to open a clean PR for it if so, otherwise I'll close this as superseded.

CC: @marblom007