Skip to content

Fix FAQ container expanding its width on content expand#266

Closed
Sujanian1304 wants to merge 5 commits into
meshery:masterfrom
Sujanian1304:bug/Sujanian1304/issue#265
Closed

Fix FAQ container expanding its width on content expand#266
Sujanian1304 wants to merge 5 commits into
meshery:masterfrom
Sujanian1304:bug/Sujanian1304/issue#265

Conversation

@Sujanian1304

Copy link
Copy Markdown

This PR fixes #265

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Piyush kumar <piyush1304kumar@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Sujanian1304, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a targeted CSS fix to address a UI anomaly where an FAQ container's width would incorrectly expand upon content interaction. By explicitly setting the width to 100% for the affected element, the change ensures consistent layout behavior and prevents unintended visual distortions, thereby enhancing the user experience within the FAQ section.

Highlights

  • CSS Styling: Introduced a width:100% property to a global style definition, specifically targeting a modal or overlay element.
  • Bug Fix: This change aims to resolve an issue where an FAQ container was expanding its width unexpectedly when its content was expanded, as referenced by issue #265.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where the FAQ container modal would expand in width as its content expanded. The fix involves adding width: 100% to the modal's styles, which effectively constrains its width relative to its parent container, preventing it from resizing with its content. The change is logical and should resolve the issue. I have one minor suggestion regarding code formatting to improve readability.

Comment thread site/src/index.style.js
margin-right: -50%;
transform: translate(-50%, -50%);
max-width: 85%;
width:100%;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to adhere to common CSS formatting standards, it's a good practice to add a space after the colon in property-value pairs.

Suggested change
width:100%;
width: 100%;

@netlify

netlify Bot commented Sep 15, 2025

Copy link
Copy Markdown

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 8f70dc5
🔍 Latest deploy log https://app.netlify.com/projects/meshery-play/deploys/69150c5efa06b800081d2acf
😎 Deploy Preview https://deploy-preview-266--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@saurabhraghuvanshii

Copy link
Copy Markdown
Member

@Sujanian1304 please add screen shot of your changes

@Sujanian1304

Copy link
Copy Markdown
Author
Screenshot 2025-09-15 234043 Screenshot 2025-09-15 234058

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in package-lock.json

Signed-off-by: piyush kumar <150425540+Sujanian1304@users.noreply.github.com>
@Sujanian1304

Copy link
Copy Markdown
Author

@Rajesh-Nagarajan-11 ,i have reverted the changes in package-lock.json

@saurabhraghuvanshii

Copy link
Copy Markdown
Member

@Sujanian1304 you didn't revert package.lock.json you just deleted that please revert

@mudassirl6 mudassirl6 mentioned this pull request Nov 17, 2025
@stale

stale Bot commented Dec 24, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/website issue/stale Issue has not had any activity for an extended period of time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Conatiner size

3 participants