Update bbox chunks recovery in VideoMatting - #66
Open
demoulinv wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how segmentation prompt metadata is recorded in the VideoMatting pipeline and adjusts bounding-box tracking extraction to support a merged tracking direction format.
Changes:
- Record segmentation prompts derived from bbox keys into
metadata_deep_model_base["Meshroom:mrSegmentation:Prompt"]inVideoMatting.py. - Update
extract_trackinginbboxUtils.pyto look formergedtracking data and simplify object/frame collection logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
segmentationRDS/bboxUtils.py |
Changes tracking extraction to prefer merged direction data when present. |
meshroom/videoMatting/VideoMatting.py |
Extracts prompt names from bbox keys and stores them in output metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how segmentation prompts are handled and optimizes the extraction of tracking data by supporting merged tracking directions. The main changes focus on enhancing metadata generation and simplifying the logic for extracting object tracking information.
Metadata and prompt handling:
VideoMatting.py, the segmentation prompt is now extracted from bounding box keys and stored in themetadata_deep_model_baseunderMeshroom:mrSegmentation:Prompt, ensuring that prompt information is consistently recorded.Tracking extraction logic:
bboxUtils.py, theextract_trackingfunction now supports amergeddirection in the tracking data. If present, it uses merged tracking data instead of separate forward/backward directions, simplifying the merging logic and making the code more robust for different tracking data formats.mergeddata exists, only those keys are used; otherwise, the function falls back to the previous forward direction logic.