Skip to content

fix(build): drop .editorconfig that breaks ktlint - #93

Merged
jamesarich merged 1 commit into
mainfrom
fix/drop-editorconfig
Jul 22, 2026
Merged

fix(build): drop .editorconfig that breaks ktlint#93
jamesarich merged 1 commit into
mainfrom
fix/drop-editorconfig

Conversation

@jamesarich

Copy link
Copy Markdown
Collaborator

The .editorconfig added in the community-health pass (#91, copied from meshtastic-sdk) broke the Lint job: ktlint reads .editorconfig, so sdk's rules now apply to mqtt's existing code and :transport-tcp:spotlessKotlinCheck (and others) fail on files nobody touched. Removing it restores a green Lint job — verified spotlessCheck passes without it. mqtt's code was already ktlint-clean under its own defaults. Adopting the org .editorconfig here would require a deliberate spotlessApply reformat (separate PR).

The .editorconfig added in the community-health pass was copied from meshtastic-sdk, but ktlint reads .editorconfig — so sdk's rules changed the formatting mqtt's existing code is checked against, and :transport-tcp:spotlessKotlinCheck (plus others) failed on files nobody touched. Remove it to restore a green Lint job. Verified spotlessCheck passes without it. Adopting the org .editorconfig would need a deliberate spotlessApply reformat (separate PR).
Copilot AI review requested due to automatic review settings July 22, 2026 12:23
@jamesarich
jamesarich enabled auto-merge July 22, 2026 12:23
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • .editorconfig
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d24a34ca-029d-4b37-96fe-36a03ebdaaf5

📥 Commits

Reviewing files that changed from the base of the PR and between 99c48b1 and ff1dda5.

📒 Files selected for processing (1)
  • .editorconfig

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamesarich
jamesarich disabled auto-merge July 22, 2026 12:26
@jamesarich
jamesarich merged commit dac2a1d into main Jul 22, 2026
12 checks passed
@jamesarich
jamesarich deleted the fix/drop-editorconfig branch July 22, 2026 12:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Removes the repo-level .editorconfig whose ktlint/spotless ruleset (copied from another project) was causing lint failures on untouched files, restoring the existing formatting/lint defaults for this codebase.

Changes:

  • Delete the .editorconfig file to stop ktlint/spotless from applying incompatible formatting rules.
  • Restore green linting by relying on the project’s prior ktlint/spotless defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants