fix(build): drop .editorconfig that breaks ktlint - #93
Conversation
The .editorconfig added in the community-health pass was copied from meshtastic-sdk, but ktlint reads .editorconfig — so sdk's rules changed the formatting mqtt's existing code is checked against, and :transport-tcp:spotlessKotlinCheck (plus others) failed on files nobody touched. Remove it to restore a green Lint job. Verified spotlessCheck passes without it. Adopting the org .editorconfig would need a deliberate spotlessApply reformat (separate PR).
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Removes the repo-level .editorconfig whose ktlint/spotless ruleset (copied from another project) was causing lint failures on untouched files, restoring the existing formatting/lint defaults for this codebase.
Changes:
- Delete the
.editorconfigfile to stop ktlint/spotless from applying incompatible formatting rules. - Restore green linting by relying on the project’s prior ktlint/spotless defaults.
The .editorconfig added in the community-health pass (#91, copied from meshtastic-sdk) broke the Lint job: ktlint reads .editorconfig, so sdk's rules now apply to mqtt's existing code and :transport-tcp:spotlessKotlinCheck (and others) fail on files nobody touched. Removing it restores a green Lint job — verified spotlessCheck passes without it. mqtt's code was already ktlint-clean under its own defaults. Adopting the org .editorconfig here would require a deliberate spotlessApply reformat (separate PR).