Skip to content

Add AQ Telemetry to userPrefs#11029

Merged
thebentern merged 1 commit into
meshtastic:developfrom
oscgonfer:enhancement/userprefs-aq-telemetry
Jul 16, 2026
Merged

Add AQ Telemetry to userPrefs#11029
thebentern merged 1 commit into
meshtastic:developfrom
oscgonfer:enhancement/userprefs-aq-telemetry

Conversation

@oscgonfer

@oscgonfer oscgonfer commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Small PR to add AQ telemetry to userPrefs.

Summary by CodeRabbit

  • New Features
    • Added configurable air-quality telemetry update intervals.
    • Added a preference to enable or disable air-quality measurements.
    • Included new template entries for configuring these air-quality settings.

@oscgonfer oscgonfer self-assigned this Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d8b283b8-01ac-4f37-9445-0d08f8946d20

📥 Commits

Reviewing files that changed from the base of the PR and between 4308487 and e8a7a50.

📒 Files selected for processing (2)
  • src/mesh/NodeDB.cpp
  • userPrefs.jsonc

📝 Walkthrough

Walkthrough

Air-quality telemetry configuration now uses optional user preference macros for its update interval and enabled state, with new commented-out entries added to the user preference template.

Changes

Air-quality telemetry configuration

Layer / File(s) Summary
Preference-driven telemetry initialization
userPrefs.jsonc, src/mesh/NodeDB.cpp
Adds commented-out preferences for air-quality telemetry and initializes the telemetry interval and enabled state from those macros, defaulting the interval to 0 when unset.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: thebentern

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits the required template sections, including attestations and testing/regression details. Replace the boilerplate with the required template content and add testing attestations, regression device checks, and any relevant issue references.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding AQ telemetry to userPrefs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oscgonfer oscgonfer added the enhancement New feature or request label Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@thebentern
thebentern merged commit f18a8b0 into meshtastic:develop Jul 16, 2026
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants