Skip to content

Replace grpcio-tools version pin with range from nanopb - #55

Merged
vidplace7 merged 1 commit into
mainfrom
dont_pin-grpcio-tools
Jul 26, 2026
Merged

Replace grpcio-tools version pin with range from nanopb#55
vidplace7 merged 1 commit into
mainfrom
dont_pin-grpcio-tools

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jul 26, 2026

Copy link
Copy Markdown
Member

grpcio-tools is pinned to >=1.43 in nanopb (where it's consumed), so match this behavior.

This was previously causing grpcio-tools to be downloaded upon every firmware build when the grpcio-tools version is not latest.

Summary by CodeRabbit

  • Chores
    • Updated the grpcio-tools version requirement to support compatible releases while avoiding breaking major-version upgrades.
    • Clarified dependency compatibility requirements in the project configuration.

grpcio-tools is pinned to >=1.43 in nanopb (where it's consumed), so match this behavior.

This was previously causing grpcio-tools to be downloaded upon every firmware build when the grpcio-tools version is not latest.
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b325ac41-a0ce-4e0e-b575-b7585830679a

📥 Commits

Reviewing files that changed from the base of the PR and between 82dfc3d and ca63798.

📒 Files selected for processing (1)
  • requirements.txt

📝 Walkthrough

Walkthrough

The grpcio-tools requirement now accepts versions from 1.43.0 up to, but excluding, 2.0, with comments documenting the constraint and related dependency ordering adjusted.

Changes

Dependency update

Layer / File(s) Summary
grpcio-tools version constraint
requirements.txt
Changes grpcio-tools from an exact pin to >=1.43.0,<2 and adds explanatory comments.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: dependencies, python

Poem

A bunny checks the version line,
From one fixed pin to ranges fine.
No major leap shall break the build,
While nanopb’s needs are fulfilled.
Hop, hop—dependencies aligned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: replacing the grpcio-tools pin with the nanopb-compatible version range.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vidplace7
vidplace7 merged commit 464e6d1 into main Jul 26, 2026
2 of 11 checks passed
@vidplace7
vidplace7 deleted the dont_pin-grpcio-tools branch July 26, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant