Skip to content

tryfix: don't use random UUID in name - #11

Open
fifieldt wants to merge 1 commit into
masterfrom
fifieldt-patch-1
Open

tryfix: don't use random UUID in name#11
fifieldt wants to merge 1 commit into
masterfrom
fifieldt-patch-1

Conversation

@fifieldt

@fifieldt fifieldt commented Nov 7, 2025

Copy link
Copy Markdown
Member

With the same name every time, this appears to work stably

With the same name every time, this appears to work stably
command:
- /bin/bash
- -c
- 'alias docker="podman"; source /.runner-meshtastic.env; cd; source bin/activate; cd runner; ./config.sh --url https://github.com/meshtastic --token $TOKEN --ephemeral --disableupdate --labels ubuntu-latest,{{ user_nickname }} --unattended --replace --name {{user_nickname}}-{{ item.runner_location }}-$UID_RANDOM --runnergroup Mesh-x86 --work _work; ./run.sh'

@CypressXt CypressXt Nov 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably replace -$UID_RANDOM by -{{item.name}}. That would allow to have predictive runner names while still allowing for multiple runners per server or location. What do you think ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, this didn't break for me since I have runner locations like this, but would break for others I guess

  9     runners:
 10       - name: fifield-65-1
 11         runner_location: 65-1
 12       - name: fifield-65-2
 13         runner_location: 65-2
 14       - name: fifield-65-3
 15         runner_location: 65-3
 16       - name: fifield-65-4
 17         runner_location: 65-4
``

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to do some flying, feel free to modify this patch over the next few days if you get time.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that make sense why it still work in your context. It might be not clearly documented on my side, I understood the runner_location as a datacenter name for example:

runner_servers:
  your-system-fqdn.tld:
    runners:
      - name: runner-1
        runner_location: datacenter-name
      - name: runner-2
        runner_location: datacenter-name

Sadly I don't have the permission to update this branch directly but I've created the PR #12 for it. Feel free to merge it if it make sense for you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants