Added description of special SNR values in RouteDiscovery

[domusonline]

…op types

This PR introduces a description (comments) on SNR special values that work as flags in the RouteDiscovery messages.
It was requested in the discussion for firmware issue 9013 (make MQTT and UDP hops clear in the traceroute displays)

Checklist before merging

• All top level messages commented
• All enum members have unique descriptions

(no changes were made)

[GUVWAF]

@garthvh @jamesarich would a separate enum for the proposed 'magic numbers' be acceptable for app implementation?

E.g.:

enum TraceRouteSNR {
  UNKNOWN = -128;
  MQTT = -127;
  UDP = 127;
}

This way we maintain the contract between firmware and API, while saving several bytes over the air.

[jamesarich]

This way we maintain the contract between firmware and API, while saving several bytes over the air.

I'm cool with this getting defined and documented and in the firmware and protocols before the clients take this on - which is the typical flow for new features .

[garthvh]

@garthvh @jamesarich would a separate enum for the proposed 'magic numbers' be acceptable for app implementation?

E.g.:

enum TraceRouteSNR {

  UNKNOWN = -128;

  MQTT = -127;

  UDP = 127;

}

This way we maintain the contract between firmware and API, while saving several bytes over the air.

Seems like kind of a hack still, can we just have a transport enum?

[fifieldt]

typo