Fix full dependencies that should be order only in ninja backend - #13377
Open
dcbaker wants to merge 3 commits into
Open
Fix full dependencies that should be order only in ninja backend#13377dcbaker wants to merge 3 commits into
dcbaker wants to merge 3 commits into
Conversation
dcbaker
force-pushed
the
submit/ninja-backend-order-only-fixes
branch
from
July 9, 2024 17:51
3897d7d to
4013ad3
Compare
dcbaker
force-pushed
the
submit/ninja-backend-order-only-fixes
branch
from
July 16, 2024 16:14
4013ad3 to
b97501d
Compare
dcbaker
force-pushed
the
submit/ninja-backend-order-only-fixes
branch
from
October 1, 2024 15:53
b97501d to
3e24341
Compare
bruchar1
reviewed
Oct 1, 2024
bruchar1
left a comment
bruchar1
left a comment
Member
There was a problem hiding this comment.
I think the third commit message could be a little more explicit. Like "refactored by adding a add_order_deps function", or something like that.
dcbaker
force-pushed
the
submit/ninja-backend-order-only-fixes
branch
from
October 1, 2024 18:14
3e24341 to
c6963bb
Compare
Member
Author
|
@bruchar1 done and done. Thanks for the review :) |
bruchar1
approved these changes
Oct 1, 2024
bruchar1
left a comment
bruchar1
left a comment
Member
There was a problem hiding this comment.
LGTM! Should it be added to the next point release?
Member
Author
I don't think so. This change potentially makes re-compiles faster when using generated headers, but it doesn't affect the correctness of the build |
header dependency are usually order-only, but this actually provides a full dependency.
Due to the confusing naming of the parameters, a number of arguments were incorrectly added as full dependencies when they should be order only.
dcbaker
force-pushed
the
submit/ninja-backend-order-only-fixes
branch
from
July 7, 2026 19:34
c6963bb to
18a9d31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current terminology is odd, it calls them "header deps" and "order deps", but headers are only order deps, and order deps are full dependencies. This renames and fixes the kind of dependencies being used.