Fix cython_args build option handling - #16003
Open
cyphercodes wants to merge 2 commits into
Open
Conversation
dcbaker
requested changes
Jul 13, 2026
| args += cython.get_option_std_args(target, target.subproject) | ||
| args += self.build.get_global_args(cython, target.for_machine) | ||
| args += self.build.get_project_args(cython, target) | ||
| args += self.environment.coredata.get_external_args(target.for_machine, cython.get_language()) |
Member
There was a problem hiding this comment.
We're in the process of deleting get_external_args, instead use:
cy_args = self.environment.coredata.optstore.get_value_for(OptionKey('cython_args', target.subproject, target.for_machine)
assert isinstance(cy_args, list), 'for mypy
args += cy_argsI might have subproject and for_machine swapped
Author
|
Addressed the review request by reading Verification:
Note: |
dcbaker
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15989.
Summary
cython_args(-Dcython_args=.../ machine-file built-in option) to Cython transpile commands.cython_argsfrom build options is passed through.Tests
python run_project_tests.py --use-tmpdir --only 'cython/3 cython_args' --failfast -v— passed (1 passed, 0 failed, 0 skipped)python run_project_tests.py --use-tmpdir --only cython --failfast— passed (6 passed, 0 failed, 0 skipped)test cases/cython/3 cython_argswith-Dcython_args='--compile-time-env BUILTIN_VALUE=1'— passed;build.ninjacontains the expected--compile-time-env BUILTIN_VALUE=1Cython args.