Handle invalid CMake skip compiler test values - #16037
Open
LunaMeerkats wants to merge 1 commit into
Open
Conversation
Author
|
CI follow-up: I inspected all five failed jobs before making any code changes.
None of the failure output points to |
LunaMeerkats
force-pushed
the
fix-cmake-skip-compiler-test-error
branch
from
July 27, 2026 23:33
45da956 to
891230f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmake_skip_compiler_testvalues through Meson's existing configuration errorFixes #13391.
Root cause
Properties.get_cmake_skip_compiler_test()asserted that the raw property was astring before its enum conversion. That prevented boolean input from reaching
the existing
ValueErrorhandler, so Meson exposed an internalAssertionErrorinstead of a normalEnvironmentException.The documented values (
always,never, anddep_only) are unchanged.Validation
AssertionErrorbefore the fixInternalTestsclass: 70 passed, 2 skippedpython run_format_tests.pypython -m compileall -q mesonbuild unittests/internaltests.pypython -m flake8 mesonbuildpython -m pylint mesonbuild/envconfig.pyA broader Windows run completed with 478 passed and 194 skipped; its 15 failures
were in unrelated platform/toolchain cases (including C#/Rust discovery and
Windows path handling). Repository-wide Pylint and MyPy were also limited by
pre-existing Python 3.14 deprecations and POSIX-only attributes on Windows.
AI assistance
OpenAI Codex assisted with issue triage, implementation, regression coverage,
validation, and diff review. The final two-file diff and recorded test evidence
were reviewed before submission.