Remove old TODOs#1481
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1481
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
NicolasHug
commented
Jun 3, 2026
| // We are seeking to the exact same frame as we are currently at. Without | ||
| // caching we have to rewind back and decode the frame again. | ||
| // TODO: https://github.com/pytorch/torchcodec/issues/84 we could | ||
| // implement caching. |
Contributor
Author
There was a problem hiding this comment.
This won't happen, corresponding issue was closed. Not the kind of optimization that is worth doing anymore with the existing seeking patterns.
NicolasHug
commented
Jun 3, 2026
|
|
||
| @pytest.mark.parametrize("device", all_supported_devices()) | ||
| @pytest.mark.parametrize("asset", (H264_10BITS, H265_10BITS)) | ||
| def test_10bit_videos(self, device, asset): |
Contributor
Author
There was a problem hiding this comment.
The logic of this test is now entirely covered by the *output_dtype* tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.