BB-876: feat: Add Script model and alias script relationship#338
Open
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Open
BB-876: feat: Add Script model and alias script relationship#338atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently there's no Script model, so aliases don't have a way to store their script. This adds that.
Solution
New
Scriptmodel formusicbrainz.scripttable, same pattern asLanguage. Addedscript()relationship onAliasmodel viascript_idforeign key. Registered inindex.ts.Areas of Impact
Only the ORM is affected, added a new model and updated alias.
script_idis nullable so nothing breaks.