fix(db): Fix multiple bugs in list_comments() filter and count logic#534
Draft
invo-coder19 wants to merge 1 commit intometabrainz:masterfrom
Draft
fix(db): Fix multiple bugs in list_comments() filter and count logic#534invo-coder19 wants to merge 1 commit intometabrainz:masterfrom
invo-coder19 wants to merge 1 commit intometabrainz:masterfrom
Conversation
This commit fixes four related bugs in critiquebrainz/db/comment.py: 1. Typo: 'commend.is_hidden' was used instead of 'comment.is_hidden', causing the SQL filter to always fail with an 'unknown table' error in strict SQL mode, or silently match nothing. 2. Inverted inc_hidden logic: The filter was only applied when inc_hidden=True (i.e., the caller explicitly wants hidden comments), but the intent of the parameter is the opposite — hidden comments should be EXCLUDED by default and only included when inc_hidden=True. This caused hidden comments to leak into all default queries. 3. Wrong total count: The function returned len(rows) which is capped at the 'limit' value (default 20). Callers using the count for pagination would compute incorrect page numbers. A separate COUNT(DISTINCT comment.id) query is now run with the same WHERE clause to return the true total. 4. Missing spaces in filter join: 'AND'.join(filters) produced broken SQL like 'col = :valANDother = :val2'. Changed to ' AND '.join(). Fixes: list_comments() in critiquebrainz/db/comment.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo: 'commend.is_hidden' was used instead of 'comment.is_hidden', causing the SQL filter to always fail with an 'unknown table' error in strict SQL mode, or silently match nothing.
Inverted inc_hidden logic: The filter was only applied when inc_hidden=True (i.e., the caller explicitly wants hidden comments), but the intent of the parameter is the opposite — hidden comments should be EXCLUDED by default and only included when inc_hidden=True. This caused hidden comments to leak into all default queries.
Wrong total count: The function returned len(rows) which is capped at the 'limit' value (default 20). Callers using the count for pagination would compute incorrect page numbers. A separate COUNT(DISTINCT comment.id) query is now run with the same WHERE clause to return the true total.