Open
Conversation
Add a sentence to the section about port publishing in the README.md. Make it clearer that this applies to people who want a database port, not just to people running a database-only server.
Improve wording of the database port publishing. Move Solr vulnerability warning to the end of the section, to make the section overall more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sentence to the section about port publishing in the README.md. Make it clearer that this applies to people who want a database port, not just to people running a database-only server.
Also move the Solr vulnerability warning to the end of the section. When it is positioned at the beginning, it distracts attention from the main point of the section, which is how to publish ports.
This addresses confusion I had when following these instructions to set up a MusicBrainz mirror server. See discussion thread at https://community.metabrainz.org/t/how-to-run-sql-queries-on-musicbrainz-docker-conveniently/807221?u=jim_delahunt .