Conversation
metal-robot
Bot
removed
the
triage
| durosValues := map[string]interface{}{ | ||
| "enabled": vp.controllerConfig.Storage.Duros.Enabled, | ||
| } | ||
| durosEnabled := vp.controllerConfig.Storage.Duros.Enabled && (cpConfig.FeatureGates.DisableDuros == nil || !*cpConfig.FeatureGates.DisableDuros) |
There was a problem hiding this comment.
Unfortunately, this only works for initial deployments due to the behavior of the chart applier, which was addressed in this PR: gardener/gardener#12251. When toggling the flag, the resources in the shoot namespace continue to exist.
Before writing complex logic to cleanup resources in the seed, maybe it's sufficient to let the seed components just continue to run. When enabling the duros-extension for the shoot, the extension can inherit the resources that are already running. However, we must be sure that all resources have equal names in this case.
There was a problem hiding this comment.
But then also we need to be aware of things like these:
during apply of object "apps/v1/Deployment/shoot--pb4b7w--gerrit2/duros-controller": Deployment.apps "duros-controller" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"duros-controller", "app.kubernetes.io/instance":"gardener-extension-duros"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
There was a problem hiding this comment.
Not sure how to proceed with this for now. Probably it's better not to add this to the upcoming metal-stack release and postpone again.
/cc @ostempel Is this ok for you?
There was a problem hiding this comment.
Not sure how to proceed with this for now. Probably it's better not to add this to the upcoming metal-stack release and postpone again.
/cc @ostempel Is this ok for you?
Yeah totally fine. We can revisite this when the time is right.
4 participants
Description
This will be required for the migration to the gardener-extension-duros.