fix: correct BayesianWAgg docs — posterior mean, not median - #104
Open
LeonidasZhak wants to merge 1 commit into
Open
fix: correct BayesianWAgg docs — posterior mean, not median#104LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
The code selects the 'mean' column from the JAGS summary output (dplyr::select(mean)), but the documentation incorrectly stated 'After obtaining the median of the posterior distribution'. Changed to 'mean' in both roxygen source and generated Rd file. Fixes metamelb-repliCATS#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80
Problem
The roxygen documentation for
BayesianWAgg()on line 42 ofR/BayesianWAgg.Rstates:But the implementation at line 417 selects the mean column from the JAGS summary output:
JAGS's `` provides both mean and median (
50%); the code uses `mean`.Fix
Changed "median" → "mean" in:
R/BayesianWAgg.R(roxygen source, line 42)man/BayesianWAgg.Rd(generated Rd, line 76)Validation
CSsamples→dplyr::select(mean)→dplyr::rename(aggregated_judgement = mean)