018 audit bug security fixes#7
Merged
timschwartz merged 4 commits intomainfrom Apr 13, 2026
Merged
Conversation
…rity fixes - Introduced a new specification document detailing user scenarios, functional requirements, and success criteria for addressing bugs and security issues identified in the audit report. - Created a quality checklist to ensure completeness and clarity of specifications before planning. - Defined measurable outcomes and assumptions related to the fixes for improved validation and testing processes.
… for audit bug and security fixes
- Added bounds checking for `getBlockByIndex` in `RpcServer` to return an error for out-of-range indices. - Refactored `validateChunk` in `ChainPersistence` to return an `std::optional<ChunkHandler>` instead of a boolean, improving error handling. - Updated `parsePeerKey` to validate port numbers, rejecting non-numeric and out-of-range values. - Enhanced `handle_sync_response` to log warnings for empty sync responses when expecting more blocks. - Added tests for new functionality, including RPC integration tests for `getBlockByIndex` and unit tests for `parsePeerKey`. - Updated the roadmap to reflect the completion of audit bug and security fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.