Skip to content

Support nested keys#119

Open
eevleevs wants to merge 1 commit intomewwts:masterfrom
eevleevs:master
Open

Support nested keys#119
eevleevs wants to merge 1 commit intomewwts:masterfrom
eevleevs:master

Conversation

@eevleevs
Copy link
Copy Markdown

Allows body['query.filtered.query.match.description']

Allows body['query.filtered.query.match.description']
@eevleevs
Copy link
Copy Markdown
Author

Partially covers #110

@mewwts
Copy link
Copy Markdown
Owner

mewwts commented Feb 28, 2020

Thanks for your contribution @eevleevs!

Will this be backwards incompatible?

@eevleevs
Copy link
Copy Markdown
Author

Could be, if one used keys including a dot until now.
But that would be a strange use case, since those keys cannot not be accessed using dot notation.

@partic2
Copy link
Copy Markdown

partic2 commented May 27, 2022

In javascript. user can use keys including dot, So I think we should not prevent user do that here either.

Maybe another function body.chain_get('query.filtered.query.match.description') is beter, Or test if raw key is exists before parse keys into nested get?

I'm not the maintainers, just in my humble opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants