Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the app’s Expo toolchain to SDK 56, aligning core React/React Native and Expo module versions and adjusting related runtime/config usage across the codebase.
Changes:
- Upgraded Expo SDK + Expo modules, React/React Native, and several supporting dependencies in
package.json. - Migrated icon usage away from
@expo/vector-iconsto@react-native-vector-icons/*across components and screens. - Updated Metro/Babel config formatting and bumped iOS
deploymentTargetinapp.config.js.
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumps Expo SDK to 56 and updates core runtime/dependency versions. |
| metro.config.js | Minor formatting/quoting adjustments around Metro/Reanimated config. |
| components/TexturedButton.tsx | Switches Ionicons import to the new vector-icons package path. |
| components/SignInPrompt.jsx | Switches MaterialIcons import to the new vector-icons package path. |
| components/PressableIcon.tsx | Switches Ionicons import to the new vector-icons package path. |
| components/MutedDialog.tsx | Switches Ionicons import to the new vector-icons package path. |
| components/MultiPlayConfigSheet.tsx | Switches MaterialIcons import to the new vector-icons package path. |
| components/HorizontalContentScroller.tsx | Switches Ionicons import to the new vector-icons package path. |
| components/Feed.tsx | Switches Ionicons import and includes minor JSX parenthesization changes. |
| components/Controls/Joystick.jsx | Switches MaterialIcons import to the new vector-icons package path. |
| components/Controls/Dpad.jsx | Switches MaterialIcons import to the new vector-icons package path. |
| components/Controls.jsx | Splits Ionicons/MaterialIcons imports to new vector-icons package paths. |
| components/CommentList.jsx | Changes useHeaderHeight import source to an Expo Router path. |
| components/CommentEditor.tsx | Switches Ionicons/MaterialIcons imports to new vector-icons package paths. |
| components/Chip.jsx | Switches Ionicons import to the new vector-icons package path. |
| components/AvatarWithIcon.jsx | Switches Ionicons import to the new vector-icons package path. |
| babel.config.js | Reformatting/normalization of Babel config structure/quoting. |
| app/projects/[id]/controls/find.jsx | Switches MaterialIcons import to the new vector-icons package path. |
| app/projects/[id]/controls/config.tsx | Switches MaterialIcons import to the new vector-icons package path. |
| app/onboarding.tsx | Switches Ionicons import to the new vector-icons package path. |
| app/multiplay.jsx | Switches MaterialIcons import to the new vector-icons package path. |
| app/error.tsx | Switches MaterialIcons import to the new vector-icons package path. |
| app/(tabs)/search.jsx | Switches Ionicons import to the new vector-icons package path. |
| app/(tabs)/index.tsx | Switches Ionicons import and includes minor JSX parenthesization changes. |
| app/_layout.tsx | Switches Ionicons/MaterialIcons imports to new vector-icons package paths. |
| app.config.js | Increases iOS deploymentTarget setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import Animated, { FadeInDown } from "react-native-reanimated"; | ||
| import { impactAsync, ImpactFeedbackStyle } from "expo-haptics"; | ||
| import { useHeaderHeight } from "@react-navigation/elements"; | ||
| import { useHeaderHeight } from "expo-router/react-navigation"; |
Owner
Author
|
All testing looks good, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Expo SDK to version 56.