Feat link out#9
Merged
Merged
Conversation
Add ExternalUrlItem component documentation\n- Update URL model to include openInNewTab property\n- Document 'External' URL state in architecture\n- Update API endpoints with new property details
🏗️ Build TSC Results |
🔍 Lint Results |
🧪 Test Results\n❌ Tests failed or did not report results correctly in s.\n\n Please check the test logs for more details. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for external URLs that open in a new browser tab. Key changes include adding a new boolean field openInNewTab to the URL model and Prisma migration, updating API payloads and type definitions, and creating the ExternalUrlItem component for rendering external links.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| prisma/schema.prisma | Added the openInNewTab field to the Url model. |
| prisma/migrations/20250624040530_add_open_in_new_tab/migration.sql | Created migration to add the new column. |
| docs/* | Updated documentation and architectural plans. |
| app/types/, app/lib/ | Updated type definitions and state management. |
| app/components/url-menu/* | Updated menu components to conditionally render ExternalUrlItem. |
| app/components/ui/UrlDialog.tsx | Added UI support for the new toggle. |
| app/api/, app/admin/urls/ | Updated API routes and admin pages to support the new field. |
🏗️ Build NextJS Results |
🏗️ Build TSC Results |
🔍 Lint Results |
🧪 Test Results\n❌ Tests failed or did not report results correctly in s.\n\n Please check the test logs for more details. |
🏗️ Build NextJS Results |
🏗️ Build TSC Results |
🔍 Lint Results |
🧪 Test Results\n❌ Tests failed or did not report results correctly in s.\n\n Please check the test logs for more details. |
🏗️ Build NextJS Results |
🏗️ Build TSC Results |
🔍 Lint Results |
🧪 Test Results\n❌ Tests failed or did not report results correctly in s.\n\n Please check the test logs for more details. |
🏗️ Build NextJS Results |
🏗️ Build TSC Results |
🧪 Test Results\n❌ Tests failed or did not report results correctly in s.\n\n Please check the test logs for more details. |
🔍 Lint Results |
🏗️ Build NextJS Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.