Skip to content

Support handleSerializationError in DlqProductionExceptionHandler for…#529

Merged
loicgreffier merged 1 commit into
michelin:mainfrom
AnkurSinhaaa:feature/Support-handleSerializationError
Jun 14, 2026
Merged

Support handleSerializationError in DlqProductionExceptionHandler for…#529
loicgreffier merged 1 commit into
michelin:mainfrom
AnkurSinhaaa:feature/Support-handleSerializationError

Conversation

@AnkurSinhaaa

@AnkurSinhaaa AnkurSinhaaa commented May 20, 2026

Copy link
Copy Markdown
Contributor

#524

Summary

Overriden handleSerializationError() in DlqProductionExceptionHandler so that serialization exceptions (e.g., poison pill records) can optionally be routed to the DLQ instead of crashing the application.

Changes

  • DlqProductionExceptionHandler – Implemented handleSerializationError() with opt-in DLQ routing controlled by a new config flag. Added JavaDoc to all methods.
  • KstreamplifyConfig – Added dlq.production-handler.continue-on-serialization-exception property constant.
  • DlqProductionExceptionHandlerTest – Added 4 tests covering: flag disabled → FAIL, flag enabled but no DLQ → FAIL, flag enabled with DLQ → RESUME + record in DLQ, internal error during handling → RESUME.
  • application.yml / README.md – Documented the new configuration property.
kafka:
  properties:
    dlq:
      production-handler:
        continue-on-serialization-exception: true

@loicgreffier loicgreffier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnkurSinhaaa Looks good for me

@loicgreffier
loicgreffier merged commit 990672c into michelin:main Jun 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants