This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Always screenshot IP when parsing xml. - #225
Open
FrankSpierings wants to merge 1 commit into
Open
Conversation
…ML scan, since the reverse DNS (PTR) name as retrieved from hostname.Name might not be resolvable.
shelld3v
approved these changes
Feb 6, 2021
asnov101
suggested changes
Apr 11, 2021
asnov101
left a comment
asnov101
left a comment
There was a problem hiding this comment.
Changes in main.go needs to be reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application will now always screenshot the IP-adres from a Nmap XML scan, since the reverse DNS (PTR) name as retrieved from hostname might not be resolvable.