Skip to content

fix(app): neutral placeholders in the WhatsApp connection modal#769

Merged
korutx merged 1 commit into
trunkfrom
fix/whatsapp-modal-neutral-placeholders
Jun 26, 2026
Merged

fix(app): neutral placeholders in the WhatsApp connection modal#769
korutx merged 1 commit into
trunkfrom
fix/whatsapp-modal-neutral-placeholders

Conversation

@korutx

@korutx korutx commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Problem

The WhatsApp connection modal used a specific tenant's real values as the placeholders for the phone-number-id and WABA-id fields (1188646904321987 / 1333560228881251). In a generic per-org card that reads like pre-filled data — and since placeholders aren't submitted, it's misleading (you still have to type the value).

Fix

Replace with localized neutral examples via i18n (modal.phoneNumberIdPlaceholder / modal.wabaIdPlaceholder → "e.g. 1234567890" / "ej. 1234567890"), matching the existing tokenPlaceholder pattern. No real identifiers in the component.

  • whatsapp-connection-modal.tsx: both placeholders → tr(...)
  • en.json / es.json: two new placeholder keys

🤖 Generated with Claude Code

Closes #771

The phone-number-id / WABA-id fields used a specific tenant's real values as
placeholders ("1188646904321987" / "1333560228881251"), which reads as pre-filled
data in a generic per-org card and is confusing (placeholders aren't submitted).

Replace with localized neutral examples (modal.phoneNumberIdPlaceholder /
wabaIdPlaceholder), matching the existing tokenPlaceholder pattern.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@korutx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 55 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6ea3fb49-2cf8-4f05-8c6d-82c1422331ec

📥 Commits

Reviewing files that changed from the base of the PR and between 800fc6c and e44f89e.

📒 Files selected for processing (3)
  • turbo-repo/apps/app/src/features/settings-admin/whatsapp/whatsapp-connection-modal.tsx
  • turbo-repo/apps/app/src/lang/en.json
  • turbo-repo/apps/app/src/lang/es.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/whatsapp-modal-neutral-placeholders

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

App preview image

The latest app preview image for this PR is ready.

  • Immutable image: ghcr.io/microboxlabs/miot-app@sha256:8c62bcf7f47c84e03b5761284814ffbfedecf34652791194d48fdc22e942b892
  • Moving tag: ghcr.io/microboxlabs/miot-app:pr-769
  • SHA tag: ghcr.io/microboxlabs/miot-app:pr-769-sha-e44f89e

@korutx korutx self-assigned this Jun 26, 2026
@korutx korutx merged commit fea6cc5 into trunk Jun 26, 2026
14 checks passed
@korutx korutx deleted the fix/whatsapp-modal-neutral-placeholders branch June 26, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(app): neutral placeholders in the WhatsApp connection modal

1 participant