Fixing tooltip in kanban#874
Conversation
📝 WalkthroughWalkthroughThis PR fixes z-index stacking issues between a kanban header and tooltip modal by adjusting Tailwind z-index classes in AbsoluteModal and SectionHeader, and reduces modal tooltip max height from 90vh to 80vh. Separately, SymptomCard rendering is refactored into a compact row layout with filtered conditions, and the symptoms grid mapping is simplified. ChangesZ-index and Modal Height Fix
Symptoms Card Compact Layout
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
App preview imageThe latest app preview image for this PR is ready.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
turbo-repo/apps/app/src/features/task-forms/components/task-bento-form/components/side-data/symptoms-card.tsx (1)
47-55: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMark
SymptomCardprops as read-only.None of
symptom,dict,loadingare markedreadonly, unlikeSymptomsCard's props further down.♻️ Suggested fix
const SymptomCard = ({ symptom, dict, loading = false, }: { - symptom: SymptomData; - dict: I18nRecord; - loading?: boolean; + readonly symptom: SymptomData; + readonly dict: I18nRecord; + readonly loading?: boolean; }) => {As per path instructions,
turbo-repo/apps/app/**/*.tsx: "Always mark React component props as read-only usingReadonly<Props>wrapper."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@turbo-repo/apps/app/src/features/task-forms/components/task-bento-form/components/side-data/symptoms-card.tsx` around lines 47 - 55, `SymptomCard` props are mutable and should match the repo rule for React components. Update the `SymptomCard` signature to use a read-only props type, mirroring the `SymptomsCard` pattern further down, so `symptom`, `dict`, and `loading` are wrapped in `Readonly<Props>` (or an equivalent read-only props alias) and the component no longer accepts mutable props.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@turbo-repo/apps/app/src/features/task-forms/components/task-bento-form/components/side-data/symptoms-card.tsx`:
- Around line 47-55: `SymptomCard` props are mutable and should match the repo
rule for React components. Update the `SymptomCard` signature to use a read-only
props type, mirroring the `SymptomsCard` pattern further down, so `symptom`,
`dict`, and `loading` are wrapped in `Readonly<Props>` (or an equivalent
read-only props alias) and the component no longer accepts mutable props.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8aca1077-00ce-45e5-ba7a-9bf972cb9502
⛔ Files ignored due to path filters (1)
turbo-repo/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
turbo-repo/apps/app/src/features/common/components/absolute-modal/absolute-modal.tsxturbo-repo/apps/app/src/features/layout/components/section-header/section-header.tsxturbo-repo/apps/app/src/features/shipping/components/modal-tooltip.tsxturbo-repo/apps/app/src/features/task-forms/components/task-bento-form/components/side-data/symptoms-card.tsx



Fixing positioning of the tooltip and background blur handling on the header of the kanban
closes #873
Summary by CodeRabbit