Master - #432
Conversation
The link was pointing to developing-testcontainers.md which doesn't exist. Corrected to developing-testcontainers/ which is the actual URL. Fixes #431 Signed-off-by: Mahitha Adapa <adapa.mahi@gmail.com>
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! 🌟 ~~~~~~~~~ 🌟 📢 If you like Microcks, please ⭐ star ⭐ our repo to support it! 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. |
The link was pointing to /distro/uber-async which doesn't exist. Corrected to /distro/uber-async-minion which is the actual directory. Fixes #433 Signed-off-by: Mahitha Adapa <adapa.mahi@gmail.com>
|
Hi @mahitha-ada , You also need to sign your PR(s) to pass the DCO check; this is mandatory. Info: https://www.secondstate.io/articles/dco/ |
|
BTW, please do not forget to star our main repo: https://github.com/microcks/microcks 🙏 |
yada
left a comment
yada
left a comment
There was a problem hiding this comment.
- Must sign your PR
- One per issue, ideally, please (or ar least mention you fix both in the PR comments)
Thank you
|
Hi @yada Thanks for the feedback! I'll split this into two separate PRs and sign them properly.
|
2 participants
Description
Fixed broken link to Testcontainers guide in deployment options documentation.
What was wrong
The link had
.mdextension:/documentation/guides/usage/developing-testcontainers.mdFix
Removed
.mdextension:/documentation/guides/usage/developing-testcontainers/Verification
Fixes #431