You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a local Dynamite ModuleDescriptor for com.google.android.gms.cast.framework.dynamite in the Cast framework core module.
The Cast framework loader already has a local CastDynamiteModuleImpl, and DynamiteLoaderImpl has a temporary version fallback for this same module id. This descriptor makes the module discoverable through the standard local descriptor path used by DynamiteModule.getLocalVersion(...).
Scope
This is intentionally small and does not claim to complete Google Cast v2 support by itself. It is a supporting fix for the Cast framework dynamite loading path related to #580.
It also does not overlap with the existing route-controller work in #3505 or the broader session/controller changes in #3377.
Validation
From a short Windows path mounted with subst G: to avoid Android AIDL path-length failures:
Builds cleanly for me — :play-services-core:assembleVtmDefaultDebug is BUILD SUCCESSFUL with this applied.
Looks correct and well-placed. DynamiteLoaderImpl.getModuleVersionV2() resolves versions by reflecting on com.google.android.gms.dynamite.descriptors.<moduleId>.ModuleDescriptor, and this lands at exactly that FQCN for com.google.android.gms.cast.framework.dynamite, so the lookup now succeeds instead of falling through to the temp-fix branch — which should clear the returning temp fix module version … Cast API wil not be functional! warning. MODULE_VERSION = 1 matches the return 1 that branch hardcoded, so the reported version is unchanged. Placing it in play-services-cast-framework/core (already pulled in by play-services-core) is consistent with how cronet/ads/maps ship their descriptors.
Optional follow-up nit: the now-dead cast.framework.dynamite branch in getModuleVersionV2() could be cleaned up later (typo "wil" and all), but that's out of scope here. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a local Dynamite
ModuleDescriptorforcom.google.android.gms.cast.framework.dynamitein the Cast framework core module.The Cast framework loader already has a local
CastDynamiteModuleImpl, andDynamiteLoaderImplhas a temporary version fallback for this same module id. This descriptor makes the module discoverable through the standard local descriptor path used byDynamiteModule.getLocalVersion(...).Scope
This is intentionally small and does not claim to complete Google Cast v2 support by itself. It is a supporting fix for the Cast framework dynamite loading path related to #580.
It also does not overlap with the existing route-controller work in #3505 or the broader session/controller changes in #3377.
Validation
From a short Windows path mounted with
subst G:to avoid Android AIDL path-length failures:Result: build successful.
Refs #580