Conversation
The separation provided by test-suite-geb seems valuable here, so I left it rather than moving the Geb specs back to test-suite
timyates
added
the
relates-to: build
|
❌ Java CI failed: https://ge.micronaut.io/s/hjkekpetbmx36 |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/6ivnygmffg2uc |
sdelamo
approved these changes
Jan 5, 2023
sdelamo
left a comment
sdelamo
left a comment
Member
There was a problem hiding this comment.
changes looks good. Do you know CI fails?
Contributor
Author
|
Investigating 👍 |
Contributor
Author
|
@sdelamo It's because security-aot isn't on master... Do we need to merge up from the 3.9.x branch? |
sdelamo
approved these changes
Jan 5, 2023
sdelamo
marked this pull request as ready for review
January 5, 2023 15:48
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The separation provided by test-suite-geb seems valuable here, so I left it rather than moving the Geb specs back to test-suite
Fixes #1190