Enable aot - #1193
Conversation
This reverts commit 1e1c6e9.
|
❌ Java CI failed: https://ge.micronaut.io/s/lyflwyndjqzwm |
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/ulexemo2kx5z2 |
|
@melix Any idea what's causing the failure? I assumed it was the public aot plugin pulling in old dependencies, but I couldn't fix it with substitutions 😞 |
|
Which failure are you talking about? Because there are many. If that's the failure about not being able to resolve some dependencies, it may be because of the change from the core BOM to the platform BOM. |
|
So just running https://ge.micronaut.io/s/6iaddsbndjsqc/console-log?page=1#L180 From my experiance, this is usually due to multiple versions of micronaut-aop being on the classpath And indeed, Could this cause it? Do annotationProcessor dependencies end up on the test classpath? Not sure what's pulling in 2.5 either 🤔 |
|
It seems to be pulling in the old version 🤔 |
The annotation process dependencies do not end up on the runtime classpath (test or not). You can see it in the build scan. It is possible that having aop 2.5 on the If we look at the build script, we see that 2 plugins are applied: https://github.com/micronaut-projects/micronaut-security/blob/enable-aot/security-aot/build.gradle.kts#L2-L3 The 1st one is the security internal module, which doesn't seem to do anything suspicious. The 2d one is the This plugin will read the After looking closely, we can see that the 2.5.0 version comes transitively from So a workaround would be to declare the BOM in annotation processor: which then yields: https://ge.micronaut.io/s/fv4ulr7muc42g/dependencies?toggled=W1sxXSxbMSwwXV0 |
Also, set the platform for the annotationProcessor, and remove an un-required test dependency
|
❌ Java CI failed: https://ge.micronaut.io/s/oafl2b4o3n4lo |
|
❌ GraalVM CE CI 17 dev failed: https://ge.micronaut.io/s/fyl6whhp52ny2 |
|
❌ Java CI failed: https://ge.micronaut.io/s/osvthaiic6lti |
|
❌ GraalVM CE CI 17 dev failed: https://ge.micronaut.io/s/uiitkexcytzrm |
|
@graemerocher @dstepanov When we re-enable the AOT module (and add the test back in), we get an error https://ge.micronaut.io/s/osvthaiic6lti/console-log?task=:security-aot:test I seem to recall this is caused by having two different versions of micronaut-aop on the test runtime classpath, however I cannot see that Do you have any idea what's wrong? As an aside, a way of showing where beans were created in the case there are multiple in error would be awesome 😉 |
# Conflicts: # security-aot/build.gradle.kts # security-aot/src/test/groovy/io/micronaut/security/aot/OpenIdProviderMetadataFetcherCodeGeneratorSpec.groovy
|
Updated the versions as well... I suspect the error will go away... CI will tell... |
|
@sdelamo running Not sure what has gone wrong at the moment... Any ideas? |
No description provided.