refactor: don’t inject bean context or event publisher - #1243
Open
sdelamo wants to merge 3 commits into
Open
Conversation
JwksCacheSpec is really flaky: https://ge.micronaut.io/scans/tests?search.timeZoneId=Europe/Madrid&tests.container=io.micronaut.security.token.jwt.signature.jwks.JwksCacheSpec Error loooks to be related to the instantiation of DefaultAccessRefreshTokenGenerator ``` Unexpected error occurred: Error instantiating bean of type [io.micronaut.security.token.jwt.generator.DefaultAccessRefreshTokenGenerator] Message: Recursive update Path Taken: new $LoginController$Definition$Intercepted(Authenticator authenticator,LoginHandler loginHandler,ApplicationEventPublisher eventPublisher,BeanResolutionContext $beanResolutionContext,BeanContext $beanContext,Qualifier $qualifier,List $interceptors) --> new $LoginController$Definition$Intercepted(Authenticator authenticator,[LoginHandler loginHandler],ApplicationEventPublisher eventPublisher,BeanResolutionContext $beanResolutionContext,BeanContext $beanContext,Qualifier $qualifier,List $interceptors) --> new AccessRefreshTokenLoginHandler([AccessRefreshTokenGenerator accessRefreshTokenGenerator]) --> new DefaultAccessRefreshTokenGenerator(AccessTokenConfiguration accessTokenConfiguration,TokenRenderer tokenRenderer,[TokenGenerator tokenGenerator],BeanContext beanContext,RefreshTokenGenerator refreshTokenGenerator,ClaimsGenerator claimsGenerator,ApplicationEventPublisher eventPublisher) io.micronaut.context.exceptions.BeanInstantiationException: Error instantiating bean of type [io.micronaut.security.token.jwt.generator.DefaultAccessRefreshTokenGenerator] Message: Recursive update ``` This PR an attempt to refactor this class to see if it helps.
|
❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/4773vomtaeyru |
|
SonarCloud Quality Gate failed. |
Contributor
|
Ran it over and over and it failed with a recursive update after 18 runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JwksCacheSpec is really flaky:
https://ge.micronaut.io/scans/tests?search.timeZoneId=Europe/Madrid&tests.container=io.micronaut.security.token.jwt.signature.jwks.JwksCacheSpec
Error loooks to be related to the instantiation of DefaultAccessRefreshTokenGenerator
This PR an attempt to refactor this class to see if it helps.