-
Notifications
You must be signed in to change notification settings - Fork 146
Bypass authentication for anonymous static resources #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sdelamo
wants to merge
9
commits into
5.4.x
Choose a base branch
from
issue-2267
base: 5.4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ad43a64
Bypass authentication for anonymous static resources
sdelamo 04a9791
Potential fix for pull request finding
sdelamo 22821f6
Potential fix for pull request finding
sdelamo d4a4618
Potential fix for pull request finding
sdelamo 58ee64a
Potential fix for pull request finding
sdelamo 77aa59d
Potential fix for pull request finding
sdelamo 3f3ca54
Potential fix for pull request finding
sdelamo d4fde66
fix chesktylemain
sdelamo e38348a
Address review: route-precedence test, docs, and drop RouteMatch close
dstepanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
...rc/main/java/io/micronaut/security/filters/DefaultStaticResourceAuthenticationBypass.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Copyright 2017-2026 original authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.micronaut.security.filters; | ||
|
|
||
| import io.micronaut.context.annotation.Requires; | ||
| import io.micronaut.core.annotation.Internal; | ||
| import io.micronaut.http.HttpMethod; | ||
| import io.micronaut.http.HttpRequest; | ||
| import io.micronaut.security.rules.ConfigurationInterceptUrlMapRule; | ||
| import io.micronaut.web.router.RouteAttributes; | ||
| import io.micronaut.web.router.resource.StaticResourceResolver; | ||
| import jakarta.inject.Singleton; | ||
|
|
||
| /** | ||
| * Default static-resource-based implementation of {@link StaticResourceAuthenticationBypass}. | ||
| */ | ||
| @Internal | ||
| @Requires(classes = { HttpRequest.class, StaticResourceResolver.class }) | ||
| @Requires(beans = { ConfigurationInterceptUrlMapRule.class, StaticResourceResolver.class }) | ||
| @Requires(missingBeans = StaticResourceAuthenticationBypass.class) | ||
| @Singleton | ||
| final class DefaultStaticResourceAuthenticationBypass implements StaticResourceAuthenticationBypass<HttpRequest<?>> { | ||
|
|
||
| private final StaticResourceResolver staticResourceResolver; | ||
| private final ConfigurationInterceptUrlMapRule interceptUrlMapRule; | ||
|
|
||
| DefaultStaticResourceAuthenticationBypass(StaticResourceResolver staticResourceResolver, | ||
| ConfigurationInterceptUrlMapRule interceptUrlMapRule) { | ||
| this.staticResourceResolver = staticResourceResolver; | ||
| this.interceptUrlMapRule = interceptUrlMapRule; | ||
| } | ||
|
|
||
| /** | ||
| * A route always takes precedence over a static resource. For an unmatched GET or HEAD | ||
| * request, resolve the resource before consulting the intercept URL map. | ||
| * | ||
| * @param request The current request | ||
| * @return Whether authentication resolution can be skipped | ||
| */ | ||
| @Override | ||
| public boolean shouldBypass(HttpRequest<?> request) { | ||
| if (!(request.getMethod() == HttpMethod.GET || request.getMethod() == HttpMethod.HEAD)) { | ||
| return false; | ||
| } | ||
| if (RouteAttributes.getRouteMatch(request).isPresent()) { | ||
| return false; | ||
| } | ||
| return staticResourceResolver.resolve(request.getUri().getPath()).isPresent() | ||
| && interceptUrlMapRule.isAnonymous(request); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
security/src/main/java/io/micronaut/security/filters/StaticResourceAuthenticationBypass.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright 2017-2026 original authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.micronaut.security.filters; | ||
|
|
||
| /** | ||
| * Decides whether authentication resolution can be skipped for a request. | ||
| * | ||
| * @since 5.4.0 | ||
| * @param <T> The Request | ||
| */ | ||
| public interface StaticResourceAuthenticationBypass<T> { | ||
|
|
||
| /** | ||
| * Whether authentication resolution can be skipped for the request. | ||
| * | ||
| * @param request The current request | ||
| * @return Whether authentication resolution can be skipped | ||
| * @since 5.4.0 | ||
| */ | ||
| boolean shouldBypass(T request); | ||
| } | ||
|
Copilot marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.