Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for OpenTelemetry span links via SpanDetails, enabling causal relationships across async/distributed operations.
Changes:
- Extend
SpanDetailsto carry optionalSpanLinks. - Pass span links into
ActivitySource.CreateActivity(...)withinOpenTelemetryScope. - Add/expand tests to validate span links are recorded/forwarded across scope types.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Scopes/SpanLinksTest.cs | Adds new tests validating span links are emitted on activities for multiple scopes. |
| src/Observability/Runtime/Tracing/Scopes/OpenTelemetryScope.cs | Plumbs SpanDetails.SpanLinks into ActivitySource.CreateActivity so activities record links. |
| src/Observability/Runtime/Tracing/Contracts/SpanDetails.cs | Adds SpanLinks to the span configuration contract. |
| src/Observability/Runtime/Tracing/Scopes/InvokeAgentScope.cs | Preserves span links when wrapping/overriding span details (span kind). |
| src/Observability/Runtime/Tracing/Scopes/ExecuteToolScope.cs | Preserves span links when wrapping/overriding span details (span kind). |
| src/Observability/Runtime/Tracing/Scopes/InferenceScope.cs | Updates docstring to reflect span links support. |
| src/Observability/Runtime/Tracing/Scopes/OutputScope.cs | Updates docstring to reflect span links support. |
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Scopes/SpanLinksTest.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Scopes/SpanLinksTest.cs
Show resolved
Hide resolved
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
juliomenendez
previously approved these changes
Apr 1, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fpfp100
reviewed
Apr 2, 2026
|
suggest adding sample data. |
fpfp100
approved these changes
Apr 2, 2026
juliomenendez
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Support span links on spans to support async services