Skip to content

fix: A365 Notification Routes Not Marked as Agentic — Deprioritized by SDK 1.4.68+ Route Ordering #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flaviocdc merged 2 commits into from
Apr 2, 2026
Merged

fix: A365 Notification Routes Not Marked as Agentic — Deprioritized by SDK 1.4.68+ Route Ordering #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e054e0a
fix: mark notification routes as agentic to prevent deprioritization
flaviocdc Apr 2, 2026
339a2e6
fix: address PR review feedback
flaviocdc Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ItemGroup>
<!-- Azure packages -->
<PackageVersion Include="Azure.Core" Version="1.50.0" />
<PackageVersion Include="Azure.Identity" Version="1.14.2" />
<PackageVersion Include="Azure.Identity" Version="1.17.1" />
<PackageVersion Include="Azure.Monitor.Ingestion" Version="1.2.0" />
<PackageVersion Include="Azure.Monitor.OpenTelemetry.Exporter" Version="1.4.0" />
<PackageVersion Include="Azure.AI.OpenAI" Version="2.7.0-beta.2" />
Expand Down Expand Up @@ -74,9 +74,9 @@
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.2" />
<!-- Security packages -->
<!-- Microsoft Agents packages (using latest available versions) -->
<PackageVersion Include="Microsoft.Agents.Builder" Version="1.3.163-beta" />
<PackageVersion Include="Microsoft.Agents.Authentication.Msal" Version="1.3.163-beta" />
<PackageVersion Include="Microsoft.Agents.Hosting.AspNetCore" Version="1.3.163-beta" />
<PackageVersion Include="Microsoft.Agents.Builder" Version="1.4.83" />
<PackageVersion Include="Microsoft.Agents.Authentication.Msal" Version="1.4.83" />
<PackageVersion Include="Microsoft.Agents.Hosting.AspNetCore" Version="1.4.83" />
<!-- Model Context Protocol packages - use only the core package -->
<PackageVersion Include="ModelContextProtocol.Core" Version="0.2.0-preview.3" />
<!-- MSTest Framework packages -->
Expand Down
10 changes: 5 additions & 5 deletions src/Notification/Microsoft.Agents.A365.Notifications/AgentNotification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ public AgentNotification OnAgentNotification(string subChannelId, AgentNotificat
{
// Wrap the activity in an AgentNotificationActivity
var agentNotificationActivity = new AgentNotificationActivity(turnContext.Activity);
// for now, we will required the handler to return the proper result.. we will change this later to return a structured result and handle the response back.
// For now, we will require the handler to return the proper result. We will change this later to return a structured result and handle the response back.
await handler(turnContext, turnState, agentNotificationActivity, cancellationToken);
};
AddRoute(_app, routeSelector, routeHandler, false, rank, autoSignInHandlers);
AddRoute(_app, routeSelector, routeHandler, isAgenticOnly: true, rank: rank, autoSignInHandlers: autoSignInHandlers);
return this;
}

Expand All @@ -83,7 +83,7 @@ public AgentNotification OnLifecycleNotification(string lifecycleEvent, AgentNot
var agentNotificationActivity = new AgentNotificationActivity(turnContext.Activity);
await handler(turnContext, turnState, agentNotificationActivity, cancellationToken);
};
AddRoute(_app, routeSelector, routeHandler, false, rank, autoSignInHandlers);
AddRoute(_app, routeSelector, routeHandler, isAgenticOnly: true, rank: rank, autoSignInHandlers: autoSignInHandlers);
return this;
}

Expand Down Expand Up @@ -285,8 +285,8 @@ public static void OnAgenticUserDeletedNotification(this AgentApplication app, A
app.RegisterExtension(new AgentNotification(app), a365 =>
{
a365.OnLifecycleNotification(Events.AgenticUserDeleted, routeHandler, rank, autoSignInHandlers);
});
});

/// <summary>
/// Creates a reply Activity containing an <see cref="EmailResponse"/> entity populated with the provided HTML body.
/// </summary>
Expand Down
Loading
Loading