Closed
Conversation
Copilot AI
added a commit
that referenced
this pull request
Mar 18, 2026
- Change LogInformation to LogDebug for agentId/tenantId logging (#5) - Configure HttpClient with explicit timeout from ExporterTimeoutMilliseconds (#8) - Add automatic periodic cleanup timer to ServiceTokenCache and AgenticTokenCache (#4) - Add IDisposable pattern to token caches with secure token clearing - Add new tests for ServiceTokenCache functionality Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
17 tasks
nikhilNava
added a commit
that referenced
this pull request
Mar 18, 2026
* Initial plan * Implement security improvements for observability packages - Change LogInformation to LogDebug for agentId/tenantId logging (#5) - Configure HttpClient with explicit timeout from ExporterTimeoutMilliseconds (#8) - Add automatic periodic cleanup timer to ServiceTokenCache and AgenticTokenCache (#4) - Add IDisposable pattern to token caches with secure token clearing - Add new tests for ServiceTokenCache functionality Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Address code review feedback for token cache cleanup timers - Use nullable Timer field instead of creating disabled timer - Fix documentation to clarify TimeSpan.Zero disables cleanup - Remove unnecessary timer overhead when cleanup is disabled Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Address code review feedback: Token memory protection, HttpClient validation, and thread-safe disposal - Make Entry.Token mutable/nullable and explicitly null before removal in ServiceTokenCache - Refactor RemoveExpiredTokens() to not use LINQ in both cache classes - Create shared HttpClientFactory with proper timeout validation (-1 for infinite) - Use Interlocked for thread-safe disposal in both cache classes - Add documentation about HttpClient reuse considerations Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.