fix: Update VM size and improve error handling for network instability#165
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves resiliency of the OneLake Index search automation by adding transient-failure retry handling, updates deployment documentation for required azd environment variables, and bumps the default VM SKU.
Changes:
- Add transient network/HTTP failure detection with exponential backoff retries in
Invoke-SearchRequest. - Update deployment guide with tenant/principal environment variables and submodule initialization note.
- Update infra parameter default VM size to
Standard_D2s_v5.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/automationScripts/OneLakeIndex/SearchHelpers.ps1 | Adds transient failure detection + retry/backoff handling for search requests. |
| infra/main.bicepparam | Updates the default VM size parameter to a v5 SKU. |
| docs/deploymentguide.md | Documents additional azd env variables and submodule init step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
Jun 8, 2026
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and updates across deployment documentation, infrastructure configuration, and automation scripts. The most significant changes include enhanced retry logic for transient network and HTTP errors in PowerShell automation scripts, updates to deployment instructions for better clarity, and a VM size update in infrastructure parameters.
Automation and Reliability Enhancements:
Test-TransientNetworkFailureinSearchHelpers.ps1to detect transient network-related exceptions, improving error handling for network instability.Invoke-SearchRequestfunction inSearchHelpers.ps1to implement exponential backoff with jitter and support for theRetry-Afterheader when retrying on transient HTTP or network errors, making retries more robust and responsive to real-world conditions. [1] [2]Documentation Improvements:
deploymentguide.mdto clarify the need to setAZURE_TENANT_IDandAZURE_PRINCIPAL_IDenvironment variables when working with non-default tenants, and marked setting the Azure location as optional.Infrastructure Update:
Standard_D2s_v4toStandard_D2s_v5inmain.bicepparamfor improved performance or cost efficiency.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information