Skip to content

fix: Update VM size and improve error handling for network instability#165

Merged
Roopan-Microsoft merged 2 commits into
microsoft:devfrom
Saswato-Microsoft:psl-dev-fixes1
Jun 8, 2026
Merged

fix: Update VM size and improve error handling for network instability#165
Roopan-Microsoft merged 2 commits into
microsoft:devfrom
Saswato-Microsoft:psl-dev-fixes1

Conversation

@Saswato-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces several improvements and updates across deployment documentation, infrastructure configuration, and automation scripts. The most significant changes include enhanced retry logic for transient network and HTTP errors in PowerShell automation scripts, updates to deployment instructions for better clarity, and a VM size update in infrastructure parameters.

Automation and Reliability Enhancements:

  • Added a new PowerShell function Test-TransientNetworkFailure in SearchHelpers.ps1 to detect transient network-related exceptions, improving error handling for network instability.
  • Enhanced the Invoke-SearchRequest function in SearchHelpers.ps1 to implement exponential backoff with jitter and support for the Retry-After header when retrying on transient HTTP or network errors, making retries more robust and responsive to real-world conditions. [1] [2]

Documentation Improvements:

  • Updated deploymentguide.md to clarify the need to set AZURE_TENANT_ID and AZURE_PRINCIPAL_ID environment variables when working with non-default tenants, and marked setting the Azure location as optional.
  • Added instructions to initialize git submodules if they were not cloned initially, preventing deployment issues due to missing dependencies.

Infrastructure Update:

  • Changed the default VM size from Standard_D2s_v4 to Standard_D2s_v5 in main.bicepparam for improved performance or cost efficiency.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI review requested due to automatic review settings June 8, 2026 12:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Improves resiliency of the OneLake Index search automation by adding transient-failure retry handling, updates deployment documentation for required azd environment variables, and bumps the default VM SKU.

Changes:

  • Add transient network/HTTP failure detection with exponential backoff retries in Invoke-SearchRequest.
  • Update deployment guide with tenant/principal environment variables and submodule initialization note.
  • Update infra parameter default VM size to Standard_D2s_v5.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
scripts/automationScripts/OneLakeIndex/SearchHelpers.ps1 Adds transient failure detection + retry/backoff handling for search requests.
infra/main.bicepparam Updates the default VM size parameter to a v5 SKU.
docs/deploymentguide.md Documents additional azd env variables and submodule init step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/automationScripts/OneLakeIndex/SearchHelpers.ps1
Comment thread scripts/automationScripts/OneLakeIndex/SearchHelpers.ps1
Comment thread scripts/automationScripts/OneLakeIndex/SearchHelpers.ps1
@Roopan-Microsoft Roopan-Microsoft merged commit d1c448b into microsoft:dev Jun 8, 2026
3 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.5.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants