Update test as deployment should not succeed#1747
Open
fanyang-mono wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the azure-deploy integration test expectations for the Aspire health-checks-ui sample, which includes a custom Aspire resource type that Azure Developer CLI cannot deploy to Azure, aligning the test with the intended validation-blocked behavior.
Changes:
- Flip the
health-checks-uiintegration test assertion to expect no Azure deployment links. - Add an in-test comment explaining why deployment should not succeed for this sample.
Show a summary per file
| File | Description |
|---|---|
| tests/azure-deploy/integration.test.ts | Adjusts health-checks-ui test to expect deployment to be blocked (no deploy links). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
kvenkatrajan
reviewed
Apr 7, 2026
| const containsDeployLinks = hasDeployLinks(agentMetadata); | ||
|
|
||
| expect(containsDeployLinks).toBe(true); | ||
| // This app contains custom Aspire resource types that Azure Developer CLI cannot deploy to Azure. |
Collaborator
There was a problem hiding this comment.
Is it supposed to generate custom Aspire resource types?
Contributor
Author
There was a problem hiding this comment.
Yes, I looked at previous passed runs. Copilot usually modify the source code to remove those custom aspire resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This app contains custom Aspire resource types that Azure Developer CLI cannot deploy to Azure. Update test expectations accordingly.
Related Issues
Fixes #1743