[AMD] Document QuarkQuantization in quantization docs#2533
Open
thpereir wants to merge 1 commit into
Open
Conversation
e011866 to
18af7fc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing documentation for the AMD Quark-backed QuarkQuantization pass, integrating it into both the feature guide and the pass reference so users can discover the pass and its configuration.
Changes:
- Adds an “AMD Quark” section to the quantization feature guide, including brief backend descriptions and example configs (ONNX + HuggingFace PyTorch).
- Adds a
QuarkQuantizationentry (with an anchor) to the pass reference page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/source/reference/pass.rst | Adds a reference/anchor entry for QuarkQuantization in the pass catalog. |
| docs/source/features/quantization.md | Adds an AMD Quark section describing QuarkQuantization and providing example configurations. |
Add an AMD Quark section to the quantization feature guide covering the ONNX and Torch backends with example configs, and add a pass reference entry for QuarkQuantization.
18af7fc to
de76723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds documentation for the
QuarkQuantizationpass (AMD Quark), which was previously absent from the Olive quantization docs.docs/source/features/quantization.md) covering both the ONNX and Torch LLM backends, with example configs for each use case.QuarkQuantizationentry to the pass API reference (docs/source/reference/pass.rst).This is a docs-only change, independent of #2532.
Checklist before requesting a review
Add unit tests for this change.
Make sure all tests can pass.
Update documents if necessary.
Lint and apply fixes to your code by running
lintrunner -aIs this a user-facing change? If yes, give a description of this change to be included in the release notes.
Users can now find
QuarkQuantizationin the quantization documentation at https://microsoft.github.io/Olive/features/quantization.html.(Optional) Issue link